Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README with timebased TopK #300

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

KalmanMeth
Copy link
Collaborator

No description provided.

Comment on lines -509 to -515
recordKey: "value"
operationKey: "value"
```

The output fields of the aggregates stage are:
- `name`
- `operation`
- `record_key`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct once #297 is merged

README.md Outdated
{"srcIP": "10.0.0.1",
"dstIP": "20.0.0.2",
"srcSubnet": "10.0.0.0/16",
"bytes": 4096,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing closing curly brace "}"

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #300 (8cb1c0c) into main (c4e2f41) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   68.98%   68.94%   -0.05%     
==========================================
  Files          82       82              
  Lines        4756     4756              
==========================================
- Hits         3281     3279       -2     
- Misses       1276     1279       +3     
+ Partials      199      198       -1     
Flag Coverage Δ
unittests 68.94% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/ingest/ingest_collector.go 48.12% <0.00%> (-1.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@KalmanMeth KalmanMeth merged commit 52ac9f5 into netobserv:main Sep 21, 2022
@KalmanMeth KalmanMeth deleted the timebased-update-readme branch January 29, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants