Add S3 encode tests #340
Merged
Add S3 encode tests #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronensc
approved these changes
Dec 7, 2022
Comment on lines
-125
to
-127
| if now.After(s.expiryTime) { | ||
| _ = s.writeObject() | ||
| } |
There was a problem hiding this comment.
IIUC, this is the only place where expiryTime is read. If it is removed from here, maybe the variable can be removed altogether.
There was a problem hiding this comment.
This is exactly for what the parameter is needed, to define the user's desired timeout period when to create a new object. So I don't think we can remove this.
Comment on lines
127
to
144
| expectedSubstring := "account1" | ||
| require.True(t, strings.Contains(objectName0, expectedSubstring)) | ||
| expectedSubstring = "year" | ||
| require.True(t, strings.Contains(objectName0, expectedSubstring)) | ||
| expectedSubstring = "month=" | ||
| require.True(t, strings.Contains(objectName0, expectedSubstring)) | ||
| expectedSubstring = "day=" | ||
| require.True(t, strings.Contains(objectName0, expectedSubstring)) | ||
| expectedSubstring = "hour=" | ||
| require.True(t, strings.Contains(objectName0, expectedSubstring)) | ||
| expectedSubstring = "stream-id=" | ||
| require.True(t, strings.Contains(objectName0, expectedSubstring)) | ||
| expectedSubstring = "00000000" | ||
| require.True(t, strings.Contains(objectName0, expectedSubstring)) | ||
| expectedSubstring = "00000001" | ||
| require.True(t, strings.Contains(fakeWriter.objectNames[1], expectedSubstring)) | ||
| expectedSubstring = "00000002" | ||
| require.True(t, strings.Contains(fakeWriter.objectNames[2], expectedSubstring)) |
There was a problem hiding this comment.
Using require.Contains() is preferred over require.True().
The advantage of require.Contains() is that when the condition is not met, the error message is more verbose.
There was a problem hiding this comment.
updated accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.