Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made prom and health server url configurable #351

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

tkuldeep
Copy link
Contributor

@tkuldeep tkuldeep commented Dec 19, 2022

  • Make address field as configurable for prom server.
  • Make health address as configurable similar to port.

Fixes #349

Signed-off-by: Kuldeep Singh Pal tkuldeep.allen@gmail.com

@codecov-commenter
Copy link

Codecov Report

Merging #351 (49433ba) into main (cba2541) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   68.89%   68.88%   -0.02%     
==========================================
  Files          87       87              
  Lines        5064     5065       +1     
==========================================
  Hits         3489     3489              
- Misses       1355     1356       +1     
  Partials      220      220              
Flag Coverage Δ
unittests 68.88% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/flowlogs-pipeline/main.go 0.00% <0.00%> (ø)
pkg/api/encode_prom.go 100.00% <ø> (ø)
pkg/config/config.go 50.00% <ø> (ø)
pkg/confgen/flowlogs2metrics_config.go 68.00% <100.00%> (+0.43%) ⬆️
pkg/operational/health.go 100.00% <100.00%> (ø)
pkg/pipeline/encode/encode_prom.go 77.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Fixes netobserv#349

Signed-off-by: Kuldeep Singh Pal <tkuldeep.allen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make prom server and health server address url configurable
3 participants