Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed timebased from default metrics defitions #380

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

KalmanMeth
Copy link
Collaborator

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kalmanmeth by writing /assign @kalmanmeth in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #380 (a1eb11c) into main (f7794d4) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   61.83%   61.83%           
=======================================
  Files          91       91           
  Lines        5977     5977           
=======================================
  Hits         3696     3696           
  Misses       2048     2048           
  Partials      233      233           
Flag Coverage Δ
unittests 61.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci openshift-ci bot added the lgtm label Feb 8, 2023
@KalmanMeth KalmanMeth merged commit 51fd6ad into netobserv:main Feb 9, 2023
@KalmanMeth KalmanMeth deleted the remove-timebased branch February 9, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants