Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Count support to timebased TopK #388

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

KalmanMeth
Copy link
Collaborator

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kalmanmeth. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KalmanMeth KalmanMeth linked an issue Feb 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@ronensc ronensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for using more meaningful names for the configs and the unit tests

@openshift-ci openshift-ci bot added the lgtm label Feb 15, 2023
@KalmanMeth KalmanMeth merged commit 0d757e7 into netobserv:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add count option to timebased topK stage
2 participants