Expose cache size as an operational metric #398
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/pipeline/encode/encode_prom.go
Outdated
| mChacheLen := operational.DefineMetric( | ||
| "encode_prom_metrics_reported", | ||
| "Total number of prometheus metrics reported by this stage", | ||
| operational.TypeGauge, | ||
| "stage", | ||
| ) |
There was a problem hiding this comment.
At the beginning of this file, there are definitions of some other operational metrics (metricsProcessed, metricsDropped and encodePromErrors). I think this definition should move there.
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 63.63% 63.78% +0.14%
==========================================
Files 92 92
Lines 6471 6481 +10
==========================================
+ Hits 4118 4134 +16
+ Misses 2113 2105 -8
- Partials 240 242 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
KalmanMeth
force-pushed
the
expose-cache-size
branch
from
02e5c20
to
d5acdf3
Compare
No description provided.