Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused (?) codecov secret #400

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 3, 2023

cc @eranra @ronensc @KalmanMeth
I'm not sure who initialized the codecov action, I think Eran?
But afaik the codecov secret is only required for private repos, and moreover, I don't think it is actually set in this workflow because "GitHub’s standard pull_request workflow trigger by default prevents write permissions and secrets access to the target repository.".

@jotak
Copy link
Member Author

jotak commented Mar 3, 2023

Note than in ebpf agent repo, we don't use any codecov secret for that action: https://github.com/netobserv/netobserv-ebpf-agent/blob/main/.github/workflows/pull_request.yml#L26-L31

@codecov-commenter
Copy link

Codecov Report

Merging #400 (f903c38) into main (9740aa3) will increase coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   61.45%   61.48%   +0.03%     
==========================================
  Files          91       91              
  Lines        6393     6393              
==========================================
+ Hits         3929     3931       +2     
+ Misses       2226     2225       -1     
+ Partials      238      237       -1     
Flag Coverage Δ
unittests 61.48% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/extract/timebased/heap.go 100.00% <0.00%> (+2.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@eranra eranra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jotak, thanks. Simple is better :-)

@jotak
Copy link
Member Author

jotak commented Mar 13, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a0ead7a into netobserv:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants