Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e test #402

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix e2e test #402

merged 1 commit into from
Mar 8, 2023

Conversation

KalmanMeth
Copy link
Collaborator

Since the prometheus port moved from encode_prom to metricsSettings, the e2e test that uses this field must be updated.

@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kalmanmeth. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KalmanMeth KalmanMeth requested review from jotak and ronensc March 8, 2023 11:05
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #402 (9e75481) into main (04f8a14) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   61.07%   61.07%           
=======================================
  Files          92       92           
  Lines        6399     6399           
=======================================
  Hits         3908     3908           
  Misses       2257     2257           
  Partials      234      234           
Flag Coverage Δ
unittests 61.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci openshift-ci bot added the lgtm label Mar 8, 2023
@KalmanMeth KalmanMeth merged commit 9ad743f into netobserv:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants