Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ConvertToBool #403

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Test ConvertToBool #403

merged 1 commit into from
Mar 14, 2023

Conversation

ronensc
Copy link
Collaborator

@ronensc ronensc commented Mar 12, 2023

This is a follow up on #401

@openshift-ci
Copy link

openshift-ci bot commented Mar 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ronensc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #403 (a3c6e30) into main (0269dcc) will increase coverage by 0.14%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   63.63%   63.77%   +0.14%     
==========================================
  Files          92       92              
  Lines        6471     6477       +6     
==========================================
+ Hits         4118     4131      +13     
+ Misses       2113     2106       -7     
  Partials      240      240              
Flag Coverage Δ
unittests 63.77% <90.90%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/convert.go 79.05% <90.90%> (+4.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ronensc ronensc merged commit 718673b into netobserv:main Mar 14, 2023
@ronensc ronensc deleted the TestConvertToBool branch March 14, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants