Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make expiryTime in encode_prom into a Duration #411

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

KalmanMeth
Copy link
Collaborator

No description provided.

@KalmanMeth KalmanMeth requested a review from ronensc March 26, 2023 11:53
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #411 (2360488) into main (9af6a7c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   64.05%   64.02%   -0.04%     
==========================================
  Files          92       92              
  Lines        6501     6501              
==========================================
- Hits         4164     4162       -2     
- Misses       2097     2098       +1     
- Partials      240      241       +1     
Flag Coverage Δ
unittests 64.02% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/encode_prom.go 100.00% <ø> (ø)
pkg/pipeline/encode/encode_prom.go 78.02% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@KalmanMeth KalmanMeth linked an issue Mar 26, 2023 that may be closed by this pull request
pkg/api/encode_prom.go Outdated Show resolved Hide resolved
pkg/config/pipeline_builder_test.go Outdated Show resolved Hide resolved
pkg/pipeline/encode/encode_prom.go Outdated Show resolved Hide resolved
pkg/pipeline/encode/encode_prom.go Outdated Show resolved Hide resolved
@KalmanMeth KalmanMeth changed the title made expirtyTime in encode_prom into a Duration make expiryTime in encode_prom into a Duration Mar 27, 2023
ronensc
ronensc previously approved these changes Mar 27, 2023
@openshift-ci openshift-ci bot added the lgtm label Mar 27, 2023
@jotak jotak added the breaking-change This pull request has breaking changes. They should be described in PR description. label Mar 27, 2023
@jotak
Copy link
Member

jotak commented Mar 27, 2023

adding the breaking change label
I don't think there's an impact on the operator, as it looks like we're using the defaults (we don't set expiryTime)

@KalmanMeth
Copy link
Collaborator Author

rebased

@KalmanMeth KalmanMeth requested a review from ronensc March 27, 2023 09:49
@openshift-ci openshift-ci bot added the lgtm label Mar 27, 2023
@KalmanMeth
Copy link
Collaborator Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KalmanMeth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KalmanMeth KalmanMeth merged commit 99a2598 into netobserv:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make expiryTime in encode_prom a Time object
4 participants