Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-962 - ADD write ipfix stage to pipeline builder #414

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

acmenezes
Copy link
Contributor

@jotak @jpinsonneau , as we spoke:

This PR adds the write ipfix stage under the FLP pipeline builder in order to be used by the operator. The methods are reachable by the operator code this way. I tested by replacing the source while I made the changes.

Changes:

  • Add WriteIpfix to pipeline_builder.go
  • Add NewWriteIpfixParams to stage_params

@acmenezes
Copy link
Contributor Author

@jpinsonneau if I'm not mistaken this PR still needs a NewIpfixPipeline and then the test based on that. I'm not sure how I should proceed for ipfix specifically. If you have any input let me know but I'll check on that as well.

@jpinsonneau
Copy link
Collaborator

@jpinsonneau if I'm not mistaken this PR still needs a NewIpfixPipeline and then the test based on that. I'm not sure how I should proceed for ipfix specifically. If you have any input let me know but I'll check on that as well.

As far as I see the NewXPipeline functions in /flowlogs-pipeline/pkg/config/pipeline_builder.go are preparing ingest stages. No changes needed there.
To test IPFIX export using the api, we can directly copy TestLokiPipeline function in /flowlogs-pipeline/pkg/config/pipeline_builder_test.go keeping the ingest + enrich stages and changing WriteLoki to WriteIpfix with proper parameters

Changes:
- Add WriteIpfix to pipeline_builder.go
- Add NewWriteIpfixParams to stage_params

Signed-off-by: acmenezes <adcmenezes@gmail.com>
@acmenezes
Copy link
Contributor Author

@jpinsonneau I guess I got it. Let me know if it's enough. I can adjust if needed. I'll pass to test in cluster if it goes well I'll convert the PR from draft to normal.

@jpinsonneau
Copy link
Collaborator

Looks good ! Thanks @acmenezes 🥇

@acmenezes acmenezes marked this pull request as ready for review April 4, 2023 19:56
@acmenezes acmenezes changed the title WIP - ADD write ipfix stage to pipeline builder ADD write ipfix stage to pipeline builder Apr 4, 2023
@acmenezes acmenezes changed the title ADD write ipfix stage to pipeline builder NETOBSERV-962 - ADD write ipfix stage to pipeline builder Apr 4, 2023
@jpinsonneau
Copy link
Collaborator

/approve to unlock netobserv/network-observability-operator#311

@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #414 (e60a292) into main (a31a0c0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   64.39%   64.41%   +0.02%     
==========================================
  Files          94       94              
  Lines        6560     6564       +4     
==========================================
+ Hits         4224     4228       +4     
  Misses       2096     2096              
  Partials      240      240              
Flag Coverage Δ
unittests 64.41% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/config/pipeline_builder.go 84.74% <100.00%> (+0.53%) ⬆️
pkg/config/stage_params.go 92.85% <100.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jpinsonneau jpinsonneau merged commit 41fe8ff into netobserv:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants