Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conntrack: Add operational metrics on errors for hash computation and aggregators #416

Merged

Conversation

ronensc
Copy link
Collaborator

@ronensc ronensc commented Mar 29, 2023

This PR adds the following operational metrics that count errors during hash computation and in the aggregators.

conntrack_aggregator_errors{error="MissingFieldError",field="Bytes"} 11
conntrack_aggregator_errors{error="Float64ConversionError",field="Bytes"} 22
conntrack_hash_errors{error="MissingFieldError",field="Missing"} 33

@ronensc ronensc added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 29, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:8fdf2a6. It will expire after two weeks.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #416 (7cc95d6) into main (381890d) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   64.62%   64.75%   +0.13%     
==========================================
  Files          94       94              
  Lines        6629     6645      +16     
==========================================
+ Hits         4284     4303      +19     
+ Misses       2101     2099       -2     
+ Partials      244      243       -1     
Flag Coverage Δ
unittests 64.75% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/test/utils.go 72.66% <ø> (ø)
pkg/pipeline/extract/conntrack/aggregator.go 98.13% <100.00%> (+2.98%) ⬆️
pkg/pipeline/extract/conntrack/conntrack.go 93.40% <100.00%> (+0.03%) ⬆️
pkg/pipeline/extract/conntrack/hash.go 84.21% <100.00%> (+0.87%) ⬆️
pkg/pipeline/extract/conntrack/metrics.go 100.00% <100.00%> (ø)
pkg/pipeline/extract/conntrack/store.go 81.37% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jpinsonneau
jpinsonneau previously approved these changes Mar 31, 2023
Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of code (not tested). Thanks @ronensc !

@openshift-ci openshift-ci bot removed the lgtm label Apr 13, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 13, 2023
@ronensc
Copy link
Collaborator Author

ronensc commented Apr 13, 2023

Rebased and added another operational metric to count how connections are getting ended per scheduling group, either by getting FIN flag or by timing out.

conntrack_end_connections{group="0: DEFAULT",reason="FIN_flag"} 11
conntrack_end_connections{group="0: DEFAULT",reason="timeout"} 22

@openshift-ci openshift-ci bot added the lgtm label Apr 13, 2023
@ronensc
Copy link
Collaborator Author

ronensc commented Apr 17, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ronensc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4aee357 into netobserv:main Apr 17, 2023
@ronensc ronensc deleted the conntrack-missing-metrics branch April 17, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants