Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-973 skip duplicates #421

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

jpinsonneau
Copy link
Collaborator

@jpinsonneau jpinsonneau commented Apr 11, 2023

When FLPs are restarted after agents, the connection store is cleared of any previous connections.

Previously, when a record containing Duplicate: true was triggering a new connection, the record sent to loki was not containing the TimeFlowEndMs field since it comes from an aggregation.

This PR skip duplicated flows in connection tracking instead of only skipping aggregates to avoid this case.

Backport: #420

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #421 (4e97779) into main (41fe8ff) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   64.42%   64.44%   +0.01%     
==========================================
  Files          94       94              
  Lines        6567     6570       +3     
==========================================
+ Hits         4231     4234       +3     
  Misses       2096     2096              
  Partials      240      240              
Flag Coverage Δ
unittests 64.44% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/extract/conntrack/conntrack.go 93.47% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jpinsonneau jpinsonneau requested a review from jotak April 11, 2023 14:15
@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 11, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Apr 11, 2023
@jotak
Copy link
Member

jotak commented Apr 11, 2023

/lgtm
but can you add more info to the PR description please? (why moving it to a different level is better)

@jpinsonneau
Copy link
Collaborator Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cfadce6 into netobserv:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants