NETOBSERV-974 Implement SASL for Kafka (producer+consumer) #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 64.74% 64.36% -0.38%
==========================================
Files 94 96 +2
Lines 6651 6690 +39
==========================================
Hits 4306 4306
- Misses 2102 2139 +37
- Partials 243 245 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jotak
added
no-qe
OlivierCazade
approved these changes
May 10, 2023
| "github.com/segmentio/kafka-go/sasl/scram" | ||
| ) | ||
|
|
||
| func SetupSASLMechanism(cfg *api.SASLConfig) (sasl.Mechanism, error) { |
There was a problem hiding this comment.
nitpick: Since the function is tied to the kafka-go type sasl.Mechanism may be it should be in the kafka ingest file.
KalmanMeth
approved these changes
May 11, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.