Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of k8s entries to ipfix export #427

Merged
merged 1 commit into from
May 30, 2023

Conversation

praveingk
Copy link
Contributor

Fixes the issue #405

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #427 (1f8d0ab) into main (4aee357) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   64.72%   64.56%   -0.17%     
==========================================
  Files          94       94              
  Lines        6645     6665      +20     
==========================================
+ Hits         4301     4303       +2     
- Misses       2100     2119      +19     
+ Partials      244      243       -1     
Flag Coverage Δ
unittests 64.56% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hack/examples/ipfix-collector/ipfix-dump.go 0.00% <0.00%> (ø)
pkg/pipeline/write/write_ipfix.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@jotak
Copy link
Member

jotak commented May 10, 2023

this looks good to me, but I'm not really involved in the ipfix export stuff - who would be more appropriate to review? cc @KalmanMeth @eranra

@jotak jotak requested a review from KalmanMeth May 10, 2023 12:57
@jotak
Copy link
Member

jotak commented May 30, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 95910af into netobserv:main May 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants