Remove error logs in processing loop

[jotak]

Errors are provided as metrics only to minimize the impact on resources, and logs readability, when an error is thrown repeatedly.

[codecov]

Codecov Report

Merging #431 (7102b27) into main (95395fc) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   64.74%   64.72%   -0.02%     
==========================================
  Files          94       94              
  Lines        6651     6654       +3     
==========================================
+ Hits         4306     4307       +1     
- Misses       2102     2104       +2     
  Partials      243      243              

Flag	Coverage Δ
unittests	64.72% <33.33%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/pipeline/ingest/ingest_grpc.go	73.97% <0.00%> (-1.03%)	⬇️
pkg/pipeline/ingest/ingest_kafka.go	65.21% <42.85%> (-0.17%)	⬇️

[jpinsonneau]

Errors are provided as metrics only to minimize the impact on resources, and logs readability, when an error is thrown repeatedly.

I disagree with this approach especially at current project state. We should give qe and end users all the necessary info to identify bugs and help us to fix these.
If you don't want to impact resources, we can simply update these to debug or trace and document how to report a bug with a step including this change.

[jotak]

@jpinsonneau So we can indeed move the logs as "trace" or "debug" but the value is low since we discourage users from setting such as level, for performance reasons. QE also don't use that in perf tests. Metrics are really the best way to get these errors.

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment