Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed generation of flow logs for more connections #432

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

KalmanMeth
Copy link
Collaborator

No description provided.

@KalmanMeth KalmanMeth requested a review from ronensc May 8, 2023 11:42
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kalmanmeth. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #432 (9379eef) into main (f8a40f8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   64.15%   64.20%   +0.05%     
==========================================
  Files          96       96              
  Lines        6723     6725       +2     
==========================================
+ Hits         4313     4318       +5     
+ Misses       2165     2163       -2     
+ Partials      245      244       -1     
Flag Coverage Δ
unittests 64.20% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/utils/connections.go 96.66% <100.00%> (+10.95%) ⬆️

@memodi
Copy link

memodi commented May 17, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 17, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:aa408a2. It will expire after two weeks.

@msherif1234
Copy link
Contributor

/ok-to-test

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 15, 2023
@openshift-ci openshift-ci bot added the lgtm label Jun 20, 2023
@KalmanMeth KalmanMeth merged commit 28adcab into netobserv:main Jun 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants