fix makefile #433
fix makefile #433
Conversation
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 64.74% 64.74%
=======================================
Files 94 94
Lines 6657 6657
=======================================
Hits 4310 4310
Misses 2104 2104
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -43,7 +43,7 @@ IMAGE_SHA = $(IMAGE_TAG_BASE):$(BUILD_SHA) | |||
|
|
|||
| # Image building tool (docker / podman) | |||
| OCI_BIN_PATH = $(shell which podman || which docker) | |||
| OCI_BIN ?= $(shell v='$(OCI_BIN_PATH)'; echo "$${v##*/}") | |||
| OCI_BIN ?= $(shell basename ${OCI_BIN_PATH}) | |||
There was a problem hiding this comment.
@KalmanMeth @ronensc following our conversation, does that works for you ?
There was a problem hiding this comment.
@jpinsonneau Yes, this change allows the build on wsl.
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.