Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github ci image argument #436

Merged

Conversation

jpinsonneau
Copy link
Collaborator

@msherif1234 it seems we missed that one 😸

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #436 (701f279) into main (ca6de5c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   64.74%   64.74%           
=======================================
  Files          94       94           
  Lines        6657     6657           
=======================================
  Hits         4310     4310           
  Misses       2104     2104           
  Partials      243      243           
Flag Coverage Δ
unittests 64.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jotak
Copy link
Member

jotak commented May 23, 2023

/lgtm
(ideally I think we should merge the manifest build/push targets inside the image build/push targets?)

@jpinsonneau
Copy link
Collaborator Author

/lgtm (ideally I think we should merge the manifest build/push targets inside the image build/push targets?)

let's followup on that in your doc 😉

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cabfa64 into netobserv:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants