Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encode s3 to pipeline builder #442

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jpinsonneau
Copy link
Collaborator

This PR simply add EncodeS3 to pipeline builder.

PS: it seems that doc was not up to date so it also update it

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #442 (78f4fee) into main (a05a86d) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   64.16%   64.12%   -0.04%     
==========================================
  Files          96       96              
  Lines        6719     6723       +4     
==========================================
  Hits         4311     4311              
- Misses       2162     2166       +4     
  Partials      246      246              
Flag Coverage Δ
unittests 64.12% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/config/pipeline_builder.go 81.96% <0.00%> (-2.78%) ⬇️
pkg/config/stage_params.go 86.66% <0.00%> (-6.20%) ⬇️

... and 1 file with indirect coverage changes

@jpinsonneau
Copy link
Collaborator Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f8a40f8 into netobserv:main Jun 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants