Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed error to warning #443

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

KalmanMeth
Copy link
Collaborator

If we use multiple encode_prom stages, each instance tries to register its operational metrics. This results in a prometheus.AlreadyRegisteredError, which is not really an error, so we convert it to a warning.

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kalmanmeth. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #443 (248f28f) into main (f8a40f8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   64.15%   64.12%   -0.03%     
==========================================
  Files          96       96              
  Lines        6723     6723              
==========================================
- Hits         4313     4311       -2     
- Misses       2165     2166       +1     
- Partials      245      246       +1     
Flag Coverage Δ
unittests 64.12% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/operational/metrics.go 75.65% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @KalmanMeth !

@openshift-ci openshift-ci bot added the lgtm label Jul 10, 2023
@KalmanMeth KalmanMeth merged commit ff26af2 into netobserv:main Jul 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants