Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile imgae-build with podman #444

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 16, 2023

@msherif1234 this is the same fix as in the operator. Also adding a 2>/dev/null on which to avoid unnecessary errors displayed repeatedly with podman

@jotak jotak requested a review from msherif1234 June 16, 2023 08:56
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #444 (9f8e0d3) into main (f8a40f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   64.15%   64.15%           
=======================================
  Files          96       96           
  Lines        6723     6723           
=======================================
  Hits         4313     4313           
  Misses       2165     2165           
  Partials      245      245           
Flag Coverage Δ
unittests 64.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234
Copy link
Contributor

/lgtm

@jotak
Copy link
Member Author

jotak commented Jun 16, 2023

/approve

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Jun 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fe6590a into netobserv:main Jun 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants