NETOBSERV-1111: Add support for RoundTripTime in FLP. #446
Conversation
dushyantbehl
changed the title
|
@dushyantbehl: This pull request references NETOBSERV-954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: quay.io/netobserv/flowlogs-pipeline:54d1bc6. It will expire after two weeks. |
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 62.79% 62.79%
=======================================
Files 96 96
Lines 6910 6916 +6
=======================================
+ Hits 4339 4343 +4
- Misses 2326 2327 +1
- Partials 245 246 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -57,6 +57,7 @@ func PBFlowToMap(flow *pbflow.Record) config.GenericMap { | |||
| "Flags": flow.Flags, | |||
| "IcmpType": flow.Icmp.GetIcmpType(), | |||
| "IcmpCode": flow.Icmp.GetIcmpCode(), | |||
| "RoundTripTimeMs": flow.TimeFlowRtt.AsDuration().Milliseconds(), | |||
There was a problem hiding this comment.
I advice to change to TimeRTTMS to align with other fields like TimeFlowStartMs
There was a problem hiding this comment.
Sure..will update I think TimeFlowRTTMs will match your example is that fine @eranra
There was a problem hiding this comment.
Updated - TimeFlowRttMs
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
|
@KalmanMeth @eranra do we need to hold these changes till the PR:netobserv/netobserv-ebpf-agent#117 gets merged? |
openshift-ci
bot
added
the
ok-to-test
|
New image: quay.io/netobserv/flowlogs-pipeline:a6d3080. It will expire after two weeks. |
Related PR - netobserv/netobserv-ebpf-agent#117 Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: quay.io/netobserv/flowlogs-pipeline:92acfb3. It will expire after two weeks. |
|
Rebased. Please take a look @eranra @jpinsonneau @KalmanMeth |
|
Thanks @jpinsonneau!! |
|
@jpinsonneau @eranra @KalmanMeth |
@dushyantbehl before approving this you need to update your ebpf agent dependency in go.mod |
dushyantbehl
added
the
breaking-change
|
@dushyantbehl: This pull request references NETOBSERV-1111 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: quay.io/netobserv/flowlogs-pipeline:b2a5acd. It will expire after two weeks. |
|
@jpinsonneau @KalmanMeth @eranra Update the go mod dependency to include newer variant of ebpf agent. The tests seem to be fine so i'm assuming we are okay now. Let me know if this lacks anything. Also, I marked the PR as |
|
cc @jotak |
|
thanks @dushyantbehl ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related PR - netobserv/netobserv-ebpf-agent#117
Since the above pull request makes changes in the ebpf agent proto buf which it exports, this PR is marked as breaking changes as we need same version of agent and flp to work together.