-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1017 extract timebased indexKeys #450
Conversation
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 62.85% 66.12% +3.27%
==========================================
Files 96 94 -2
Lines 6916 6867 -49
==========================================
+ Hits 4347 4541 +194
+ Misses 2325 2066 -259
- Partials 244 260 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/utils/convert.go
Outdated
case string: | ||
return i, nil | ||
default: | ||
v := reflect.ValueOf(unk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could't we use fmt.Sprintf(%v) to convert anything to a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, b8cc564
t[k] = values[i] | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you've added in the individual fields, I don't see the need to keep the key
, operation_key
, and operation_result
fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly; done in 25842d7
Thanks @KalmanMeth 🥳 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@KalmanMeth @jpinsonneau should we mark that as a breaking change? (the API is preserved however the output fields are different if I understand correctly (operation_key and operation_result being removed) I'm not concerned for netobserv, but other FLP users |
Added the label on that PR. Check #450 (comment) discussion |
@jpinsonneau For completeness we should mark it as a breaking change (although you did maintain back compatibility for the current implementation, indicating deprecation). |
In order to get top Pod / Service talkers this PR implements
IndexKeys
as an array fortimebased
stage.It also add the capability to index on non string fields using
ConvertToString
utils