Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1186: extract DNS flags rcode field and stringify it #451

Merged
merged 1 commit into from
Jul 13, 2023
Merged

NETOBSERV-1186: extract DNS flags rcode field and stringify it #451

merged 1 commit into from
Jul 13, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 11, 2023 •
edited

  • try compress out unused fields to reduce flp generated map size
  • for dns tracker extract and decode response code so it can be used as UI filter

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 11, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-1186 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited

Codecov Report

Merging #451 (cfb2b10) into main (ff26af2) will decrease coverage by 0.16%.
The diff coverage is 63.09%.

@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   62.85%   62.69%   -0.16%     
==========================================
  Files          96       96              
  Lines        6916     6970      +54     
==========================================
+ Hits         4347     4370      +23     
- Misses       2325     2356      +31     
  Partials      244      244
Flag Coverage Δ
unittests 62.69% <63.09%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/decode/decode_protobuf.go 29.79% <63.09%> (+2.90%) ⬆️

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 11, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:86f203e. It will expire after two weeks.

@jpinsonneau
Copy link
Collaborator

New image: quay.io/netobserv/flowlogs-pipeline:86f203e. It will expire after two weeks.

Thanks @msherif1234 ! That works perfectly with front end.

A small change will be needed for Drops filter -> Without drops case as it was checking for "TcpDropPackets":0 but the other cases works fine.
I'm preparing a PR for this and the new ResponseCode field

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 12, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 12, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:a6271d3. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 12, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 12, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-1186 which is a valid jira issue.

In response to this:

  • try compress out unused fields to reduce flp generated map size
  • for dns tracker extract and decode response code so it can be used as UI filter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 12, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:084ecfb. It will expire after two weeks.

@jpinsonneau jpinsonneau mentioned this pull request Jul 12, 2023
Closed
jpinsonneau
jpinsonneau previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @msherif1234

@openshift-ci openshift-ci bot added the lgtm label Jul 13, 2023
@msherif1234
Copy link
Contributor Author

/approve

@msherif1234
NETOBSERV-1186: extract DNS flags rcode field and stringify it
cfb2b10 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 13, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 13, 2023
@jotak
Copy link
Member

jotak commented Jul 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 13, 2023
@jotak
Copy link
Member

jotak commented Jul 13, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4e3576e into netobserv:main Jul 13, 2023
8 checks passed
@jpinsonneau jpinsonneau mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalmanMeth KalmanMeth Awaiting requested review from KalmanMeth

@jotak jotak Awaiting requested review from jotak

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@jotak jotak

@jpinsonneau jpinsonneau

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@msherif1234 @openshift-ci-robot @jpinsonneau @jotak @KalmanMeth @openshift-merge-robot