Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade linter - fix found issues - use go1.20 #452

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 12, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #452 (b1c8191) into main (ff26af2) will increase coverage by 3.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   62.85%   66.36%   +3.51%     
==========================================
  Files          96       94       -2     
  Lines        6916     6755     -161     
==========================================
+ Hits         4347     4483     +136     
+ Misses       2325     2016     -309     
- Partials      244      256      +12     
Flag Coverage Δ
unittests 66.36% <ø> (+3.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/transform/kubernetes/kubernetes.go 19.36% <ø> (ø)

... and 8 files with indirect coverage changes

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak
Copy link
Member Author

jotak commented Jul 18, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e2359a8 into netobserv:main Jul 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants