-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move add_if and add_regex_if to transform_filter from transform_network #453
move add_if and add_regex_if to transform_filter from transform_network #453
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 66.15% 66.15%
=======================================
Files 94 94
Lines 6867 6867
=======================================
Hits 4543 4543
Misses 2065 2065
Partials 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@KalmanMeth could you rebase please? Some CI checks aren't triggered because you it is several weeks behind |
11caaab
to
7ae760f
Compare
done |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=4f2115e make set-flp-image |
I just verified that there is no regression with netobserv (these moved rules aren't used, so that's fine) /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.