move add_if and add_regex_if to transform_filter from transform_network

[KalmanMeth]

No description provided.

[codecov]

Codecov Report

Patch coverage: 77.27% and no project coverage change.

Comparison is base (7513aa9) 66.15% compared to head (7ae760f) 66.15%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          94       94           
  Lines        6867     6867           
=======================================
  Hits         4543     4543           
  Misses       2065     2065           
  Partials      259      259           

Flag	Coverage Δ
unittests	66.15% <77.27%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/api/transform_filter.go	100.00% <ø> (ø)
pkg/api/transform_network.go	83.33% <ø> (ø)
pkg/pipeline/transform/transform_network.go	72.56% <ø> (-0.56%)	⬇️
pkg/pipeline/transform/transform_filter.go	89.23% <77.27%> (-6.12%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jotak]

cc @ronensc @eranra wdyt?
It would be a breaking change of course, but it sounds like some of the filters were wrongly defined as "network filters" whereas they were completely unrelated to network.
We'll need to document this change (and how to "migrate") in the release note

[jotak]

@KalmanMeth could you rebase please? Some CI checks aren't triggered because you it is several weeks behind main

[KalmanMeth]

@KalmanMeth could you rebase please? Some CI checks aren't triggered because you it is several weeks behind main

done

[github-actions]

New image:
quay.io/netobserv/flowlogs-pipeline:4f2115e

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4f2115e make set-flp-image

[jotak]

I just verified that there is no regression with netobserv (these moved rules aren't used, so that's fine)
Code looks good to me

/lgtm

[KalmanMeth]

@jotak @ronensc I think this PR just needs a formal approval from a reviewer before we can merge.

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment