Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msherif1234 #454

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Add msherif1234 #454

merged 1 commit into from
Jul 17, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 13, 2023

No description provided.

@jotak jotak requested a review from msherif1234 July 13, 2023 16:19
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #454 (bc56156) into main (f022140) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files          96       96           
  Lines        6916     6916           
=======================================
  Hits         4347     4347           
  Misses       2325     2325           
  Partials      244      244           
Flag Coverage Δ
unittests 62.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jotak
Copy link
Member Author

jotak commented Jul 17, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f62730c into netobserv:main Jul 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants