Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for missing labels #463

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 25, 2023

@KalmanMeth here's a test that clarifies the behaviour that IMO we should keep, wrt to missing labels and #460

@jotak jotak requested a review from KalmanMeth July 25, 2023 09:18
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #463 (9587d47) into main (f771d4b) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   66.20%   66.15%   -0.05%     
==========================================
  Files          94       94              
  Lines        6808     6867      +59     
==========================================
+ Hits         4507     4543      +36     
- Misses       2046     2065      +19     
- Partials      255      259       +4     
Flag Coverage Δ
unittests 66.15% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Is it related to a specific story ?

@jotak
Copy link
Member Author

jotak commented Aug 2, 2023

@jpinsonneau that was related to this ticket #464 where the proposed fix was to ignore counting records for metrics when there are missing labels, but that would have broken a bunch of things, hence this added test to write in stone the expected behaviour here.
Thanks for the review!
/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 31e9d82 into netobserv:main Aug 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants