Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go validation check #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dushyantbehl
Copy link
Contributor

Fixes #461

The older PR got closed by mistake, referencing it here - #462

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eranra for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #467 (f1b40e5) into main (e2359a8) will increase coverage by 0.15%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   66.17%   66.32%   +0.15%     
==========================================
  Files          94       94              
  Lines        6808     6899      +91     
==========================================
+ Hits         4505     4576      +71     
- Misses       2047     2065      +18     
- Partials      256      258       +2     
Flag Coverage Δ
unittests 66.32% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FLP go validation fails for me on MAC.
1 participant