Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1111 Change RTT output to ns #468

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

dushyantbehl
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #468 (b3cab32) into main (e2359a8) will decrease coverage by 0.02%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   66.17%   66.15%   -0.02%     
==========================================
  Files          94       94              
  Lines        6808     6867      +59     
==========================================
+ Hits         4505     4543      +38     
- Misses       2047     2065      +18     
- Partials      256      259       +3     
Flag Coverage Δ
unittests 66.15% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/pipeline/decode/decode_protobuf.go 29.55% <100.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @dushyantbehl

@openshift-ci openshift-ci bot added the lgtm label Aug 1, 2023
@jpinsonneau jpinsonneau changed the title Change RTT output to ns NETOBSERV-1111 Change RTT output to ns Aug 1, 2023
@dushyantbehl
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dushyantbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 89f2c60 into netobserv:main Aug 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants