Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1135: add ovs subsystem drop causes #472

Merged
merged 1 commit into from
Aug 17, 2023
Merged

NETOBSERV-1135: add ovs subsystem drop causes #472

merged 1 commit into from
Aug 17, 2023

Conversation

msherif1234
Copy link
Contributor

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 16, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-1135 which is a valid jira issue.

In response to this:

OVS drop support just merged upstream
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/net/openvswitch/drop.h

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited

Codecov Report

Merging #472 (b3679ee) into main (5912edf) will decrease coverage by 0.24%.
The diff coverage is 3.12%.

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   66.08%   65.85%   -0.24%     
==========================================
  Files          94       94              
  Lines        6877     6899      +22     
==========================================
- Hits         4545     4543       -2     
- Misses       2071     2094      +23     
- Partials      261      262       +1
Flag Coverage Δ
unittests 65.85% <3.12%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/pipeline/decode/decode_protobuf.go 28.39% <3.12%> (-2.12%) ⬇️

... and 1 file with indirect coverage changes

jpinsonneau
jpinsonneau previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! 🚀

@openshift-ci openshift-ci bot added the lgtm label Aug 16, 2023
@openshift-ci openshift-ci bot removed the lgtm label Aug 16, 2023
jpinsonneau
jpinsonneau approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also fine with the new approach, merging switch / cases 👍

@openshift-ci openshift-ci bot added the lgtm label Aug 17, 2023
@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0fd6e81 into netobserv:main Aug 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

Assignees

@jpinsonneau jpinsonneau

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msherif1234 @openshift-ci-robot @jpinsonneau @openshift-merge-robot