-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1247: using Meta informer for replicaSets #474
Conversation
@msherif1234: This pull request references NETOBSERV-1247 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-1247 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=27c0dcf make set-flp-image |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
- Coverage 67.07% 66.90% -0.17%
==========================================
Files 94 94
Lines 6724 6741 +17
==========================================
Hits 4510 4510
- Misses 1948 1965 +17
Partials 266 266
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
17d1862
to
f45bd4e
Compare
/ok-to-test |
@msherif1234: This pull request references NETOBSERV-1247 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=c6e2afd make set-flp-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, not tested yet
Do you see differences in the enriched flows ?
$ oc get rs -A | wc -l
343 if we ignore few flp pods with PR showing much higher usage then I would say this is mostly the same , I am not able to increase RS to lagre number w/o increasing current default of 250 pods/node which prevented me from swapping FLP images to test before and after |
So do you think it's not worth it or should it be verified by QEs ? |
I think QE verified on scale run we might have better numbers there @memodi WDYT ? |
I guess the idea here to rollout the new revisions to existing deployments, we don't have any tool that does that today. Simply, increasing the cluster size won't help since FLP pods would scale equally. |
@msherif1234 @jpinsonneau - does all FLP tries to build similar cache? I am trying to think if we had say 120 node cluster with 100 deployments on each worker would be appropriate scenario? cc @nathan-weinberg |
Yes every FLP build the exact same cache. That's why the kube API is taking a burst on Netobserv startup
So you would be around |
/rm-ok-test |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=89ba22d make set-flp-image |
@msherif1234 hope you don"t mind :) I pushed a fix on this PR, FLP was CLBO due to a wrong conversion, the transform func now expecting partial metadata rather than replicaset |
/lgtm |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=217cdb2 make set-flp-image |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
e31c3af
to
0dd22d5
Compare
(cherry picked from commit 0da2955e9738d2b5a53d716e7d1cbe5fddffc5f3)
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=e98f7ba make set-flp-image |
/hold cancel |
/label qe-approved |
@msherif1234: This pull request references NETOBSERV-1247 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is follow up to the work @jpinsonneau started in https://github.com/jpinsonneau/flowlogs-pipeline/tree/update_metainformer