Update README and config #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Codecov Report
@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 66.03% 66.03%
=======================================
Files 94 94
Lines 6921 6921
=======================================
Hits 4570 4570
Misses 2092 2092
Partials 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jpinsonneau
reviewed
Aug 23, 2023
| @@ -437,6 +454,7 @@ parameters: | |||
| filter: | |||
| key: name | |||
| value: dest_service_count | |||
| filters: [] | |||
There was a problem hiding this comment.
filter is deprecated in favor of filters so we should convert these to arrays
KalmanMeth
reviewed
Aug 24, 2023
Comment on lines
258
to
260
| filter: | ||
| key: name | ||
| key: "" | ||
| value: "" |
There was a problem hiding this comment.
Since filter is being deprecated, shouldn't we just delete this section?
KalmanMeth
approved these changes
Aug 28, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ronensc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the feedback of @aslom in #473:
make ocp-deploywithIMAGE_ORG=netobservextract_aggregatewhich required this update.flp_op_(added underscore) to avoid metric names likeflp_opmetrics_processed