Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1222: create PR template #490

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 13, 2023

FYI @KalmanMeth @ronensc , not sure if you were aware of this planned change: we're adding this PR template to help guiding contributors through the processes, across all repos used in operator context.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 13, 2023

@jotak: This pull request references NETOBSERV-1222 which is a valid jira issue.

In response to this:

FYI @KalmanMeth @ronensc , not sure if you were aware of this planned change: we're adding this PR template to help guiding contributors through the processes, across all repos used in operator context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (058bc4e) 66.03% compared to head (cae412e) 66.09%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   66.03%   66.09%   +0.06%     
==========================================
  Files          94       94              
  Lines        6921     6948      +27     
==========================================
+ Hits         4570     4592      +22     
- Misses       2092     2095       +3     
- Partials      259      261       +2     
Flag Coverage Δ
unittests 66.09% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member Author

jotak commented Sep 13, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit db6ebea into netobserv:main Sep 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants