Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a couple of minor weaknesses #491

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 14, 2023

Description

Some weaknesses were detected, fixing here a bunch of them, especially inconsistent null-checks or suppressed errors

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Some weaknesses were detected, fixing here a bunch of them, especially
inconsistent null-checks or suppressed errors
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 75.32% and project coverage change: -0.04% ⚠️

Comparison is base (058bc4e) 66.03% compared to head (c008960) 65.99%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   66.03%   65.99%   -0.04%     
==========================================
  Files          94       94              
  Lines        6921     6964      +43     
==========================================
+ Hits         4570     4596      +26     
- Misses       2092     2102      +10     
- Partials      259      266       +7     
Flag Coverage Δ
unittests 65.99% <75.32%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/api/transform_filter.go 100.00% <ø> (ø)
pkg/pipeline/write/write_ipfix.go 0.00% <0.00%> (ø)
cmd/flowlogs-pipeline/main.go 48.93% <33.33%> (-0.71%) ⬇️
pkg/pipeline/encode/encode_kafka.go 58.97% <42.85%> (-2.67%) ⬇️
pkg/pipeline/extract/timebased/filters.go 81.41% <66.66%> (-3.13%) ⬇️
pkg/pipeline/extract/aggregate/aggregate.go 93.24% <78.94%> (-2.62%) ⬇️
pkg/pipeline/ingest/ingest_kafka.go 63.73% <85.71%> (+0.57%) ⬆️
pkg/pipeline/transform/transform_filter.go 89.13% <88.88%> (-0.11%) ⬇️
pkg/pipeline/ingest/ingest_synthetic.go 93.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member Author

jotak commented Sep 14, 2023

thanks @KalmanMeth
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9043619 into netobserv:main Sep 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants