Fix crash when metrics settings are unset #537
Conversation
It's panic'ing with: panic: runtime error: invalid memory address or nil pointer dereference Due to ConnectionInfo being a pointer
jotak
added
no-qe
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@KalmanMeth @OlivierCazade I think that's what made the e2e test fail in #532 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 95 95
Lines 6802 6802
=======================================
Hits 4547 4547
Misses 1988 1988
Partials 267 267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -154,7 +154,7 @@ func ParseConfig(opts Options) (ConfigFileStruct, error) { | |||
| } | |||
| logrus.Debugf("metrics settings = %v ", out.MetricsSettings) | |||
| } else { | |||
| logrus.Errorf("metrics settings missing") | |||
| logrus.Infof("using default metrics settings") | |||
There was a problem hiding this comment.
If metrics settings are absent then will the port be 0?
There was a problem hiding this comment.
right - I take care of this in this other PR: #538
It's panic'ing with:
panic: runtime error: invalid memory address or nil pointer dereference
Due to ConnectionInfo being a pointer
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.