Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1514: drop go1.20 support #629

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 12, 2024

I had to upgrade the linter, and took that opportunity to enable more linters (same config as what we have on the agent)
But that led to quite a lot of fixes, this is why the PR is pretty big; There's no (intentional) functional changes

@jotak jotak changed the title drop go1.20 support NETOBSERV-1514: drop go1.20 support Mar 12, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 12, 2024

@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 78.96679% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 67.05%. Comparing base (ddc1f67) to head (382fd38).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/pipeline/extract/conntrack/store.go 76.66% 7 Missing ⚠️
pkg/api/write_loki.go 16.66% 1 Missing and 4 partials ⚠️
pkg/confgen/confgen.go 42.85% 3 Missing and 1 partial ⚠️
pkg/pipeline/encode/metrics_common.go 80.95% 4 Missing ⚠️
pkg/pipeline/utils/sasl.go 0.00% 4 Missing ⚠️
pkg/pipeline/write/write_loki.go 0.00% 4 Missing ⚠️
pkg/confgen/extract.go 50.00% 3 Missing ⚠️
pkg/pipeline/transform/location/location.go 76.92% 3 Missing ⚠️
pkg/test/utils.go 57.14% 3 Missing ⚠️
cmd/confgenerator/main.go 50.00% 2 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   67.02%   67.05%   +0.03%     
==========================================
  Files         110      110              
  Lines        7676     7677       +1     
==========================================
+ Hits         5145     5148       +3     
  Misses       2217     2217              
+ Partials      314      312       -2     
Flag Coverage Δ
unittests 67.05% <78.96%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 12, 2024

@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

I had to upgrade the linter, and took that opportunity to enable more linters (same config as what we have on the agent)
But that led to quite a lot of fixes, this is why the PR is pretty big; There's no (intentional) functional changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 12, 2024
Copy link

New image:
quay.io/netobserv/flowlogs-pipeline:d37829b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d37829b make set-flp-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 12, 2024
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 12, 2024
Copy link

New image:
quay.io/netobserv/flowlogs-pipeline:c80abff

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=c80abff make set-flp-image

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak
Copy link
Member Author

jotak commented Mar 14, 2024

/approve

Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fee143f into netobserv:main Mar 14, 2024
12 checks passed
@jotak jotak deleted the drop-1.20 branch March 21, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants