Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide k8s templates to just deploy an ipfix collector #633

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 14, 2024

No description provided.

@jotak jotak mentioned this pull request Mar 14, 2024
11 tasks
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.05%. Comparing base (ddc1f67) to head (e53b124).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   67.02%   67.05%   +0.02%     
==========================================
  Files         110      110              
  Lines        7676     7676              
==========================================
+ Hits         5145     5147       +2     
+ Misses       2217     2216       -1     
+ Partials      314      313       -1     
Flag Coverage Δ
unittests 67.05% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jotak
/lgtm
@Amoghrd - can you please try it out with FLP as collector? I think it's worth adding it in our test case while we figure what we can we do about go-ipfix collector

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 14, 2024

Will do

@jotak
Copy link
Member Author

jotak commented Mar 15, 2024

/approve

Copy link

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4a8953c into netobserv:main Mar 15, 2024
9 checks passed
@jotak jotak deleted the ipfix-collector-template branch March 21, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants