Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent maps #634

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix inconsistent maps #634

merged 2 commits into from
Mar 18, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 15, 2024

Description

Fix inconsistent maps received from the agent depending on the export mode (grpc / kafka / direct-flp)

Dependencies

Depends on netobserv/netobserv-ebpf-agent#297

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 15, 2024
Copy link

New image:
quay.io/netobserv/flowlogs-pipeline:470a56c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=470a56c make set-flp-image

@jotak jotak requested a review from msherif1234 March 15, 2024 14:47
Fix inconsistent maps received from the agent depending on the export
mode (grpc / kafka / direct-flp)

Depends on netobserv/netobserv-ebpf-agent#297
@openshift-ci openshift-ci bot removed the lgtm label Mar 18, 2024
Copy link

openshift-ci bot commented Mar 18, 2024

New changes are detected. LGTM label has been removed.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 18, 2024
@jotak
Copy link
Member Author

jotak commented Mar 18, 2024

/approve

Copy link

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit bb139cb into netobserv:main Mar 18, 2024
6 of 8 checks passed
@jotak jotak deleted the consistent-generic-map branch March 21, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants