Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update examples, minor changes #635

Merged
merged 1 commit into from
Mar 20, 2024
Merged

update examples, minor changes #635

merged 1 commit into from
Mar 20, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 18, 2024

  • running make generate-configuration
  • remove unused AddIfRuleType
  • renamed parseTransport -> parseTransform
  • add omitempty to some api

@jotak
update examples, minor changes
2a54565 
- running `make generate-configuration`
- remove unused AddIfRuleType
- renamed parseTransport -> parseTransform
- add omitempty to some api
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Mar 18, 2024
@jotak
Copy link
Member Author

jotak commented Mar 18, 2024

/retest-required

@jotak
Copy link
Member Author

jotak commented Mar 19, 2024

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 2a54565 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

OlivierCazade
OlivierCazade approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2024
@jotak
Copy link
Member Author

jotak commented Mar 20, 2024

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit b1ccc26 into netobserv:main Mar 20, 2024
8 of 10 checks passed
@jotak jotak deleted the update-examples branch March 21, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@KalmanMeth KalmanMeth Awaiting requested review from KalmanMeth

Assignees

@OlivierCazade OlivierCazade

Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jotak @OlivierCazade