Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Add logs - give some workaround for prom registry issue #685

Closed
wants to merge 1 commit into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 16, 2024

Description

Related to https://issues.redhat.com/browse/NETOBSERV-1748 (but not fixing it)
Add some logs, add provide some workaround when the issue comes up

More work needs to be done to restart a fresh new registry

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak jotak requested a review from OlivierCazade July 16, 2024 11:55
Copy link

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 16.27907% with 36 lines in your changes missing coverage. Please review.

Project coverage is 65.12%. Comparing base (915552b) to head (2c7f28e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   65.12%   65.12%           
=======================================
  Files         107      107           
  Lines        6844     6844           
=======================================
  Hits         4457     4457           
  Misses       2070     2070           
  Partials      317      317           
Flag Coverage Δ
unittests 65.12% <16.27%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/pipeline/utils/timed_cache.go 95.06% <100.00%> (ø)
pkg/pipeline/encode/encode_prom.go 40.79% <14.28%> (ø)

@jotak
Copy link
Member Author

jotak commented Jul 17, 2024

superseded by #686

@jotak jotak closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant