NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf agent #103

msherif1234 · 2023-03-15T19:14:44Z

Extend L4 protocols support to include

SCTP
ICMPv4
ICMPv6

Note: SCTP structure is not exported hence I am using local version of it in the ebpf code I checked with RHEL team and they said this probably fine because its very unlikely this structure will ever change and there is no plans to exported either.

unit-testing

ipv4: 07:58:14.541222 enp1s0 IP 192.168.122.69:0 > 192.168.122.1:0: protocol:icmp type: 8 code: 0 dir:1 bytes:490 packets:5 flags:0 ends: 07:58:18.637230
ipv4: 07:58:14.541512 enp1s0 IP 192.168.122.1:0 > 192.168.122.69:0: protocol:icmp type: 0 code: 0 dir:0 bytes:490 packets:5 flags:0 ends: 07:58:18.637502

codecov · 2023-03-15T19:20:21Z

Codecov Report

Merging #103 (55d9dd3) into main (8eb86a9) will decrease coverage by 0.29%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   41.88%   41.59%   -0.29%     
==========================================
  Files          30       30              
  Lines        2008     2041      +33     
==========================================
+ Hits          841      849       +8     
- Misses       1129     1154      +25     
  Partials       38       38

Flag	Coverage Δ
unittests	`41.59% <23.52%> (-0.29%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/ebpf/tracer.go	`0.00% <0.00%> (ø)`
pkg/exporter/ipfix.go	`0.00% <0.00%> (ø)`
pkg/exporter/proto.go	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

go.mod

msherif1234 · 2023-03-19T15:11:57Z

/ok-to-test

github-actions · 2023-03-19T15:13:31Z

New image: ["quay.io/netobserv/netobserv-ebpf-agent:e6854dd"]. It will expire after two weeks.

bpf/flows.c

praveingk

Looks good 👍🏽

msherif1234 · 2023-03-20T12:22:41Z

/ok-to-test

openshift-ci-robot · 2023-03-20T12:22:47Z

@msherif1234: This pull request references NETOBSERV-934 which is a valid jira issue.

In response to this:

Extend L4 protocols support to include

SCTP

ICMPv4

ICMPv6

Note: SCTP structure is not exported hence I am using local version of it in the ebpf code I checked with RHEL team and they said this probably fine because its very unlikely this structure will ever change and there is no plans to exported either.

unit-testing
ipv4: 07:58:14.541222 enp1s0 IP 192.168.122.69:0 > 192.168.122.1:0: protocol:icmp type: 8 code: 0 dir:1 bytes:490 packets:5 flags:0 ends: 07:58:18.637230
ipv4: 07:58:14.541512 enp1s0 IP 192.168.122.1:0 > 192.168.122.69:0: protocol:icmp type: 0 code: 0 dir:0 bytes:490 packets:5 flags:0 ends: 07:58:18.637502

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-actions · 2023-03-20T12:25:42Z

New image: ["quay.io/netobserv/netobserv-ebpf-agent:6dbf3dd"]. It will expire after two weeks.

bpf/flows.c

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 · 2023-03-20T14:31:05Z

/ok-to-test

github-actions · 2023-03-20T14:32:55Z

New image: ["quay.io/netobserv/netobserv-ebpf-agent:4c509fc"]. It will expire after two weeks.

jotak · 2023-03-20T14:55:20Z

/lgtm
/approve
thanks @msherif1234 !

openshift-ci · 2023-03-20T14:55:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netobserv#103) * Add support for SCTP, ICMP amd ICMPv6 protocols to ebpf code Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com> * update GRPC protobuf definition to include icmp fields Signed-off-by: msherif1234 <mmahmoud@redhat.com> * Add ICMP and ICMPv6 ipfix support Signed-off-by: msherif1234 <mmahmoud@redhat.com> * Add ICMPv4/6 ebpf agent support Signed-off-by: msherif1234 <mmahmoud@redhat.com> * Update unit-test cases Signed-off-by: msherif1234 <mmahmoud@redhat.com> * Add verifier error check to catch JIT errors Signed-off-by: msherif1234 <mmahmoud@redhat.com> * update flowlogs dump collector tool to include ICMP Signed-off-by: msherif1234 <mmahmoud@redhat.com> --------- Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com> Signed-off-by: msherif1234 <mmahmoud@redhat.com>

openshift-ci bot added the do-not-merge/work-in-progress label Mar 15, 2023

msherif1234 changed the title ~~WIP: Add support for SCTP, ICMP amd ICMPv6 protocols to ebpf code~~ Add support for SCTP, ICMP amd ICMPv6 protocols to ebpf code Mar 16, 2023

openshift-ci bot removed the do-not-merge/work-in-progress label Mar 16, 2023

msherif1234 requested review from praveingk and mariomac March 16, 2023 14:03

jpinsonneau mentioned this pull request Mar 16, 2023

added ICMP fields netobserv/flowlogs-pipeline#407

Closed

jotak reviewed Mar 17, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

msherif1234 requested a review from jotak March 17, 2023 13:13

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 19, 2023

praveingk reviewed Mar 20, 2023

View reviewed changes

bpf/flows.c Show resolved Hide resolved

praveingk previously approved these changes Mar 20, 2023

View reviewed changes

openshift-ci bot assigned praveingk Mar 20, 2023

openshift-ci bot added the lgtm label Mar 20, 2023

openshift-merge-robot added the needs-rebase label Mar 20, 2023

msherif1234 dismissed praveingk’s stale review via 7c04604 March 20, 2023 12:03

openshift-ci bot removed the lgtm label Mar 20, 2023

openshift-merge-robot removed the needs-rebase label Mar 20, 2023

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 20, 2023

msherif1234 requested a review from praveingk March 20, 2023 12:07

msherif1234 changed the title ~~Add support for SCTP, ICMP amd ICMPv6 protocols to ebpf code~~ NETOBSERV-934: Add support for SCTP, ICMP amd ICMPv6 protocols to ebpf code Mar 20, 2023

openshift-ci-robot added the jira/valid-reference label Mar 20, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 20, 2023

msherif1234 changed the title ~~NETOBSERV-934: Add support for SCTP, ICMP amd ICMPv6 protocols to ebpf code~~ NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf code Mar 20, 2023

msherif1234 changed the title ~~NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf code~~ NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf agent Mar 20, 2023

praveingk reviewed Mar 20, 2023

View reviewed changes

bpf/flows.c Outdated Show resolved Hide resolved

msherif1234 added 7 commits March 20, 2023 10:11

Add support for SCTP, ICMP amd ICMPv6 protocols to ebpf code

5e6a639

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>

update GRPC protobuf definition to include icmp fields

212a9b6

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

Add ICMP and ICMPv6 ipfix support

46ae860

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

Add ICMPv4/6 ebpf agent support

7f1e9de

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

Update unit-test cases

50e0056

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

Add verifier error check to catch JIT errors

4719850

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

update flowlogs dump collector tool to include ICMP

55d9dd3

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 20, 2023

msherif1234 requested a review from praveingk March 20, 2023 14:14

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 20, 2023

praveingk approved these changes Mar 20, 2023

View reviewed changes

openshift-ci bot added the lgtm label Mar 20, 2023

openshift-ci bot assigned jotak Mar 20, 2023

openshift-ci bot added the approved label Mar 20, 2023

openshift-merge-robot merged commit c62173a into netobserv:main Mar 20, 2023

msherif1234 mentioned this pull request Mar 20, 2023

NETOBSERV-934: Add icmpv4/v6 bits to FLP netobserv/flowlogs-pipeline#408

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf agent #103

NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf agent #103

msherif1234 commented Mar 15, 2023 •

edited

Loading

codecov bot commented Mar 15, 2023 •

edited

Loading

msherif1234 commented Mar 19, 2023

github-actions bot commented Mar 19, 2023

praveingk left a comment

msherif1234 commented Mar 20, 2023

openshift-ci-robot commented Mar 20, 2023 •

edited by openshift-ci bot

Loading

github-actions bot commented Mar 20, 2023

msherif1234 commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

jotak commented Mar 20, 2023

openshift-ci bot commented Mar 20, 2023

NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf agent #103

NETOBSERV-934: Add support for SCTP, ICMPv4/v6 protocols to ebpf agent #103

Conversation

msherif1234 commented Mar 15, 2023 • edited Loading

codecov bot commented Mar 15, 2023 • edited Loading

Codecov Report

msherif1234 commented Mar 19, 2023

github-actions bot commented Mar 19, 2023

praveingk left a comment

Choose a reason for hiding this comment

msherif1234 commented Mar 20, 2023

openshift-ci-robot commented Mar 20, 2023 • edited by openshift-ci bot Loading

github-actions bot commented Mar 20, 2023

msherif1234 commented Mar 20, 2023

github-actions bot commented Mar 20, 2023

jotak commented Mar 20, 2023

openshift-ci bot commented Mar 20, 2023

msherif1234 commented Mar 15, 2023 •

edited

Loading

codecov bot commented Mar 15, 2023 •

edited

Loading

openshift-ci-robot commented Mar 20, 2023 •

edited by openshift-ci bot

Loading