Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-977: some interfaces on single stack cluster can have both ipv4 and ipv6 linklocal #108

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Apr 10, 2023

We need to filter out interfaces with linklocal ips when we decide which socket type to use to connect to google dns server here is an example

2: enp0s20f0u5u2c2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UNKNOWN group default qlen 1000
    link/ether fa:14:54:36:5a:55 brd ff:ff:ff:ff:ff:ff
    inet 169.254.3.1/24 brd 169.254.3.255 scope link dynamic noprefixroute enp0s20f0u5u2c2
       valid_lft 855315sec preferred_lft 855315sec
    inet6 fe80::2021:58f:8cf9:eca6/64 scope link noprefixroute 
       valid_lft forever preferred_lft forever

We need to filter out those interfaces when we decide which
socket type to use to connect to google dns server

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 10, 2023

@msherif1234: This pull request references NETOBSERV-977 which is a valid jira issue.

In response to this:

We need to filter out those interfaces when we decide which socket type to use to connect to google dns server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 10, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/netobserv-ebpf-agent:d037698"]. It will expire after two weeks.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #108 (9a3f45e) into main (2dca243) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   41.80%   41.80%           
=======================================
  Files          30       30           
  Lines        2050     2050           
=======================================
  Hits          857      857           
  Misses       1155     1155           
  Partials       38       38           
Flag Coverage Δ
unittests 41.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/ip.go 71.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 11, 2023

@msherif1234: This pull request references NETOBSERV-977 which is a valid jira issue.

In response to this:

We need to filter out interfaces with linklocal ips when we decide which socket type to use to connect to google dns server here is an example

2: enp0s20f0u5u2c2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UNKNOWN group default qlen 1000
   link/ether fa:14:54:36:5a:55 brd ff:ff:ff:ff:ff:ff
   inet 169.254.3.1/24 brd 169.254.3.255 scope link dynamic noprefixroute enp0s20f0u5u2c2
      valid_lft 855315sec preferred_lft 855315sec
   inet6 fe80::2021:58f:8cf9:eca6/64 scope link noprefixroute 
      valid_lft forever preferred_lft forever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 changed the title NETOBSERV-977: some interfaces could have both ipv4 and ipv6 linklocal NETOBSERV-977: some interfaces on single stack cluster can have both ipv4 and ipv6 linklocal Apr 11, 2023
@Amoghrd
Copy link

Amoghrd commented Apr 11, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Apr 11, 2023
@jotak
Copy link
Member

jotak commented Apr 11, 2023

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit beb50b3 into netobserv:main Apr 11, 2023
dushyantbehl pushed a commit to dushyantbehl/netobserv-ebpf-agent that referenced this pull request Apr 28, 2023
netobserv#108)

We need to filter out those interfaces when we decide which
socket type to use to connect to google dns server

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants