Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-753: Reset ticker if flows flushed when cacheMaxFlows is reached #114

Merged
merged 1 commit into from
May 10, 2023
Merged

NETOBSERV-753: Reset ticker if flows flushed when cacheMaxFlows is reached #114

merged 1 commit into from
May 10, 2023

Conversation

msherif1234
Copy link
Contributor

ebpf agent optimization to avoid unnecessary flows eviction when cacheMaxFlows is reached followed by evictTick timer expiry

…ached

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 25, 2023

@msherif1234: This pull request references NETOBSERV-753 which is a valid jira issue.

In response to this:

ebpf agent optimization to avoid unnecessary flows eviction when cacheMaxFlows is reached followed by evictTick timer expiry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #114 (7be21eb) into main (beb50b3) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   41.80%   41.88%   +0.08%     
==========================================
  Files          30       30              
  Lines        2050     2053       +3     
==========================================
+ Hits          857      860       +3     
  Misses       1155     1155              
  Partials       38       38              
Flag Coverage Δ
unittests 41.88% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/flow/account.go 83.33% <100.00%> (+0.98%) ⬆️

@msherif1234
Copy link
Contributor Author

/assign @jotak

@openshift-ci openshift-ci bot added the lgtm label May 10, 2023
@jotak jotak added no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval labels May 10, 2023
@jotak
Copy link
Member

jotak commented May 10, 2023

Thanks @msherif1234 !
/approve

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msherif1234 msherif1234 merged commit 3698de1 into netobserv:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants