DONTMERGE: NETOBSERV-983: avoid preallocating huge chunk of memory by default

[msherif1234]

using BPF_F_NO_PREALLOC to allocate memory as needed and avoid default preallocation to help with better scale

for reference https://www.kernel.org/doc/html/next/bpf/map_hash.html

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-975 which is a valid jira issue.

In response to this:

using BPF_F_NO_PREALLOC to allocate memory as needed and avoid default preallocation to help with better scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from msherif1234. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-975 which is a valid jira issue.

In response to this:

using BPF_F_NO_PREALLOC to allocate memory as needed and avoid default preallocation to help with better scale

for reference https://www.kernel.org/doc/html/next/bpf/map_hash.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #119 (7e64030) into main (3f192b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   41.80%   41.80%           
=======================================
  Files          30       30           
  Lines        2050     2050           
=======================================
  Hits          857      857           
  Misses       1155     1155           
  Partials       38       38           

Flag	Coverage Δ
unittests	41.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[msherif1234]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/netobserv-ebpf-agent:d8ab1c2"]. It will expire after two weeks.

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-983 which is a valid jira issue.

In response to this:

using BPF_F_NO_PREALLOC to allocate memory as needed and avoid default preallocation to help with better scale

for reference https://www.kernel.org/doc/html/next/bpf/map_hash.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msherif1234]

/ok-to-test

[jotak]

@dushyantbehl and/or @praveingk that's just a small config change ; does it seems good to you?

[msherif1234]

if we are migrating to global hashmap #118 then there is no need for this PR I am already taking care of the same there
/hold

[dushyantbehl]

Looks good to me.

[dushyantbehl]

if we are migrating to global hashmap #118 then there is no need for this PR I am already taking care of the same there /hold

@msherif1234 Even with a global hashmap I believe the spirit of your approach works which is just lazy allocation of the Hashmap memory so I feel this can be added even if we have global or local hashmap.

[msherif1234]

if we are migrating to global hashmap #118 then there is no need for this PR I am already taking care of the same there /hold

@msherif1234 Even with a global hashmap I believe the spirit of your approach works which is just lazy allocation of the Hashmap memory so I feel this can be added even if we have global or local hashmap.

right the global hashmap PR has the same change as well hence we won't need this PR anymore once the #118 merge