Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new approvers #125

Merged
merged 1 commit into from
May 24, 2023
Merged

Add new approvers #125

merged 1 commit into from
May 24, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented May 23, 2023

No description provided.

@jotak
Copy link
Member Author

jotak commented May 23, 2023

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #125 (3dbc3ee) into main (4acf15c) will increase coverage by 41.32%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main     #125       +/-   ##
=========================================
+ Coverage      0   41.32%   +41.32%     
=========================================
  Files         0       31       +31     
  Lines         0     2081     +2081     
=========================================
+ Hits          0      860      +860     
- Misses        0     1183     +1183     
- Partials      0       38       +38     
Flag Coverage Δ
unittests 41.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

@msherif1234
Copy link
Contributor

/lgtm

@dushyantbehl
Copy link
Contributor

Thanks @jotak @msherif1234

@dushyantbehl
Copy link
Contributor

/verify-owners

@msherif1234
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 23, 2023
@github-actions
Copy link

New image: quay.io/netobserv/netobserv-ebpf-agent:c8fcb97. It will expire after two weeks.

@jotak
Copy link
Member Author

jotak commented May 24, 2023

/verify-owners

@jotak
Copy link
Member Author

jotak commented May 24, 2023

/approve

Welcome aboard @shach33 @dushyantbehl !

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5017b42 into netobserv:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants