Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile targetarch scope with docker #128

Merged
merged 1 commit into from
May 24, 2023

Conversation

OlivierCazade
Copy link
Contributor

Tested locally with both podman and docker.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #128 (a75b2ea) into main (80337e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   41.32%   41.32%           
=======================================
  Files          31       31           
  Lines        2081     2081           
=======================================
  Hits          860      860           
  Misses       1183     1183           
  Partials       38       38           
Flag Coverage Δ
unittests 41.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see the difference with my local versions but still works as expected 👍

Should we do that for all repos ?

@jotak
Copy link
Member

jotak commented May 24, 2023

/lgtm
/approve
thanks!

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3df4bfe into netobserv:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants