Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make docker-generate issue #137 #138

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix make docker-generate issue #137 #138

merged 1 commit into from
Jun 20, 2023

Conversation

msherif1234
Copy link
Contributor

No description provided.

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from msherif1234. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dushyantbehl dushyantbehl self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #138 (6d9bcfb) into main (5680c55) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files          31       31           
  Lines        2054     2054           
=======================================
  Hits          834      834           
  Misses       1181     1181           
  Partials       39       39           
Flag Coverage Δ
unittests 40.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234 msherif1234 added no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval labels Jun 20, 2023
@dushyantbehl
Copy link
Contributor

Fixes #137
/lgtm /approve

Copy link
Contributor

@dushyantbehl dushyantbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug.

@openshift-ci openshift-ci bot added the lgtm label Jun 20, 2023
@dushyantbehl dushyantbehl merged commit d79f7ba into netobserv:main Jun 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants