Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM Z (s390x) #139

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Add IBM Z (s390x) #139

merged 1 commit into from
Jun 21, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 21, 2023

No description provided.

@jotak jotak added no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval labels Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #139 (ae5ea09) into main (d79f7ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files          31       31           
  Lines        2054     2054           
=======================================
  Hits          834      834           
  Misses       1181     1181           
  Partials       39       39           
Flag Coverage Δ
unittests 40.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234
Copy link
Contributor

/lgtm

@dushyantbehl
Copy link
Contributor

/lgtm

@jotak
Copy link
Member Author

jotak commented Jun 21, 2023

thanks for the quick review!
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 96e8f61 into netobserv:main Jun 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants